add structured dracon logging #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
northdpole
force-pushed
the
structured-logging
branch
from
8d6d4c4 to
39bae1e
Compare
Merged
northdpole
force-pushed
the
structured-logging
branch
3 times, most recently
from
468b655 to
9769adf
Compare
ptzianos
reviewed
Jun 4, 2024
northdpole
force-pushed
the
structured-logging
branch
from
cb2d5f7 to
04034cd
Compare
ptzianos
reviewed
Jun 4, 2024
northdpole
force-pushed
the
structured-logging
branch
from
723dfb2 to
5d8be44
Compare
northdpole
force-pushed
the
structured-logging
branch
from
5d8be44 to
8696501
Compare
northdpole
force-pushed
the
structured-logging
branch
from
8696501 to
e50b519
Compare
ptzianos
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages Go's
log/slogpackage to add a default logger to every logging statement we have in the project.This allows us to change logging for all components easily and in the future be more flexible with smarter things like tracing or making groups out of our logs.
Enrichers do not have a base method for now so they don't get structured logging, this is coming in the next PR